QPPC-0000 updatedocker #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
aokasb
commented
May 12, 2023
| FROM jupyter/datascience-notebook | ||
|
|
||
| RUN pip install tabulate pytest | ||
|
|
There was a problem hiding this comment.
pytest was not available in the previous docker also the python version was 3.6
|
That reminds me ( regarding Java 11 docker update ) , this one I worked on last week. |
ckawell-sb
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for change
This is related to QPPC-4141 I realized that the docker is not "general purpose docker" and its python version restricts some of the things which can be done. This PR is meant to update the docker from
https://hub.docker.com/r/bayesimpact/c2q-data-analysis to a generic docker and ensure all the scripts can be executed through that.
What is being changed
Release checklist:
Tasks that must be done prior to merging this PR, including testing.
Associated JIRA tickets: