Remove deprecations in portals #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
No ticket
🛠 Changes
ℹ️ Context
The portals contain a number of deprecated behaviors that seem worth fixing. I made some other changes just to reduce noise in the testing.
Enums were deprecated because the old format will break with next Rails upgrade.
The fix for removing Redis.current is somewhat naive; there are more complex fixes involving pooling, but instantiation is not really very expensive, and its use is for sending emails in the sandbox (which is not particularly common). So an ideal fix seems like overengineering.
I also updated rubocop, because I was getting odd errors with the older version.
🧪 Validation
Automated tests all pass and no deprecations in the output.