Redirect to credentials tab when AO creates credential #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdettmannnava
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4375
🛠 Changes
credential_startparameter added to show organizationℹ️ Context
By default, when the AO looks at an organization, they start on the credential delegate tab. We want them to see the credentials tab if the last thing they did was create (or delete) a credential. Adding a parameter to the redirect seemed to be the easiest way to do this.
I only changed the signature of CompoundShowComponent to reduce the number of changes to the system, though now it does not match the CredentialDelegate::ListComponent. I changed the signature to address rubocop disliking signatures with too many inputs.
🧪 Validation
Manual and automated testing.