Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4353 run automated accessibility tests #2315

Merged
merged 31 commits into from
Nov 5, 2024

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Nov 4, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-4353

🛠 Changes

  • Added github workflow to manually run accessibility tests
  • Execution script added to install headless Firefox and run axe tests
  • Axe gems added to Gemfile
  • Endpoint necessary for testing added to invitations controller (has to be a GET for capybara to execute)
  • Rspec configuration changed to not automatically run accessibility tests, allow calls to github
  • Accessibility test

ℹ️ Context

We want to be able to run accessibility tests on the portal, but we do not want their failure to block deployment, nor do we want the overhead (~400MB) of having headless Firefox in the image.

Calls to github had to be opened up because capybara will fail if you don't.

🧪 Validation

Run make ci-portal-accessibility

Ran on CI: https://github.com/CMSgov/dpc-app/actions/runs/11687943610/job/32547218425

@jdettmannnava jdettmannnava marked this pull request as ready for review November 5, 2024 16:22
@jdettmannnava jdettmannnava requested a review from a team November 5, 2024 16:22
@jdettmannnava jdettmannnava changed the title DPC-4128 run automated accessibility tests DPC-4353 run automated accessibility tests Nov 5, 2024
Copy link
Contributor

@chris-ronning-ny chris-ronning-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will review the tests themselves separately!

@jdettmannnava jdettmannnava merged commit 3ca0dcb into main Nov 5, 2024
8 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4128-accessibility-3 branch November 5, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants