Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --ignore CVE-2015-9284 from dpc-admin Dockerfile #2305

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove --ignore CVE-2015-9284 from dpc-admin Dockerfile #2305

merged 1 commit into from
Oct 29, 2024

Conversation

jdettmannnava
Copy link
Contributor

🎫 Ticket

No ticket

🛠 Changes

  • csrf protection upgraded to 1
  • omniauth-github upgraded to 2
  • omniauth-oktaoauth removed
  • ignore CVE-2015-9284 removed from Dockerfile

ℹ️ Context

Seeing if we could remove CVE-2015-9284 from Dockerfile

🧪 Validation

  • Builds
  • On deploy to dev, can still log in

@jdettmannnava jdettmannnava changed the title Update omniauth-github Remove --ignore CVE-2015-9284 from dpc-admin Dockerfile Oct 29, 2024
@jdettmannnava jdettmannnava marked this pull request as ready for review October 29, 2024 18:44
@jdettmannnava jdettmannnava requested a review from a team October 29, 2024 18:44
ashley-weaver
ashley-weaver approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdettmannnava jdettmannnava merged commit 4e179ae into main Oct 29, 2024
8 checks passed
@jdettmannnava jdettmannnava deleted the jd/remove-cv-ignore branch October 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashley-weaver ashley-weaver ashley-weaver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdettmannnava @ashley-weaver