Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPC-4334] Government System Banner / System Use Agreement #2293

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

chris-ronning-ny
Copy link
Contributor

@chris-ronning-ny chris-ronning-ny commented Oct 21, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-4334

🛠 Changes

  • Create a static page for the System Use Agreement. I separated this from the main application.html.erb in order to simplify some page style changes -- namely, spacing and background color. This allows me to match the style specified in the image on the ticket.
  • Add a toggle to remove the bottom border from the header, in order to match the style specified in the image on the ticket.
  • Create the link and text to the system use agreement and add it to the invitation login and the main login page.

ℹ️ Context

We want to link users to a government system use agreement when they are prompted to login.

🧪 Validation

  • Manual testing
  • Unit testing
System Use Agreement Screenshot 2024-10-21 at 1 52 29 PM Screenshot 2024-10-21 at 1 52 21 PM

@chris-ronning-ny chris-ronning-ny requested a review from a team October 21, 2024 17:53
Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks great!

<div class="font-body-2xs margin-bottom-3">
<span>
By signing in with Login.gov, you are agreeing to our
<%= link_to system_use_agreement_path do %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a target to open in a new tab/window

@chris-ronning-ny
Copy link
Contributor Author

@jdettmannnava added target: :_blank, and it opens in a new tab now.

Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-ronning-ny chris-ronning-ny merged commit c0e0ea5 into main Oct 22, 2024
8 checks passed
@chris-ronning-ny chris-ronning-ny deleted the cr/dpc-4334 branch October 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants