-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPC-4334] Government System Banner / System Use Agreement #2293
Conversation
…emoval of bottom border
…login component and the login component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks great!
<div class="font-body-2xs margin-bottom-3"> | ||
<span> | ||
By signing in with Login.gov, you are agreeing to our | ||
<%= link_to system_use_agreement_path do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a target to open in a new tab/window
@jdettmannnava added target: :_blank, and it opens in a new tab now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎫 Ticket
https://jira.cms.gov/browse/DPC-4334
🛠 Changes
application.html.erb
in order to simplify some page style changes -- namely, spacing and background color. This allows me to match the style specified in the image on the ticket.ℹ️ Context
We want to link users to a government system use agreement when they are prompted to login.
🧪 Validation