Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4258 Run sonarqube check in GitHub actions #2273

Merged
merged 68 commits into from
Sep 20, 2024

Conversation

jdettmannnava
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-4258

🛠 Changes

  • Saved results of tests from webapps' workflows for use in sonarqube evaluation
  • Added sonarqube evaluations of portal, web/admin, and app

ℹ️ Context

We had been running sonarqube evaluation in deployment, but it makes much more sense to have code analysis/failure block merge than deployment, so we moved it here.

🧪 Validation

  • Checked output of ci-workflow and verified that sonarqube runs for each context
  • Tested dpc-app by adding class without corresponding test; failed github action
  • Tested dpc-web by adding class without corresponding test; failed github action
  • Tested dpc-admin by adding class without corresponding test; failed github action
  • Tested dpc-portal by adding class without corresponding test; failed github action

@jdettmannnava jdettmannnava requested a review from a team September 20, 2024 15:45
@jdettmannnava jdettmannnava marked this pull request as ready for review September 20, 2024 15:45
@jdettmannnava jdettmannnava marked this pull request as draft September 20, 2024 15:50
@jdettmannnava jdettmannnava marked this pull request as ready for review September 20, 2024 17:50
Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more last minute SQ failures on deploy! 🥳

@jdettmannnava jdettmannnava merged commit 302c040 into main Sep 20, 2024
8 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4258-sonarqube-github-actions branch September 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants