Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPC-4273] Added tip with alternative steps to resolve build failures in manual dpc-app build steps. #2272

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[DPC-4273] Added tip with alternative steps to resolve build failures in manual dpc-app build steps. #2272

merged 1 commit into from
Sep 19, 2024

Conversation

NavaCharlesHorowitz
Copy link
Contributor

@NavaCharlesHorowitz NavaCharlesHorowitz commented Sep 19, 2024 •
edited
Loading

🎫 Ticket

[DPC-4273]

🛠 Changes

  • Updated README.md to include alternative steps for building the api if a build failure is encountered when following the existing procedure.

ℹ️ Context

  • Following README.md steps on a new laptop as part of corporate/project onboarding, a build failure was encountered running mvn clean install.
  • M. Esposito suggested alternative steps to resolve build failure.
  • Steps were verified and build was successful.
  • Revising README.md as basic intro/test of dev methodology and tools, as well as to include useful tip in README.md

🧪 Validation

  • Re-tested alternative steps and verified build is successful.

@NavaCharlesHorowitz NavaCharlesHorowitz added the good first issue Good for newcomers label Sep 19, 2024
@NavaCharlesHorowitz NavaCharlesHorowitz requested a review from a team September 19, 2024 12:27
@NavaCharlesHorowitz NavaCharlesHorowitz self-assigned this Sep 19, 2024
chris-ronning-ny
chris-ronning-ny approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@chris-ronning-ny chris-ronning-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad you're able to get things up and running. One request, can you finish the sentence in the Changes section of the PR description before you merge?

@NavaCharlesHorowitz NavaCharlesHorowitz merged commit 5c9d3f6 into main Sep 19, 2024
5 checks passed
@NavaCharlesHorowitz NavaCharlesHorowitz deleted the ceh1/DPC-4273 branch September 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ronning-ny chris-ronning-ny chris-ronning-ny approved these changes

Assignees

@NavaCharlesHorowitz NavaCharlesHorowitz

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NavaCharlesHorowitz @chris-ronning-ny