Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPC-4244 logout of login #2263

Merged
merged 10 commits into from
Sep 9, 2024
Merged

DPC-4244 logout of login #2263

merged 10 commits into from
Sep 9, 2024

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Sep 6, 2024 •
edited
Loading

🎫 Ticket

https://jira.cms.gov/browse/DPC-4244

🛠 Changes

  • Changed default logout behavior to manually log out then redirect to idp for them to log out
  • Added logged_out response to logindotgov controller to handle return from above
  • Consolidated idp environment variables in application controller

ℹ️ Context

We want users to be able to log out of the idp after they log out of the portal.
Required update to idp to allow redirect to logged_out

🧪 Validation

Manual and automated testing

@jdettmannnava jdettmannnava marked this pull request as ready for review September 6, 2024 15:17
@jdettmannnava jdettmannnava requested a review from a team September 6, 2024 15:17
chris-ronning-ny
chris-ronning-ny approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@chris-ronning-ny chris-ronning-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdettmannnava jdettmannnava merged commit 8199a33 into main Sep 9, 2024
5 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4244-logout-of-login branch September 9, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ronning-ny chris-ronning-ny chris-ronning-ny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdettmannnava @chris-ronning-ny