Skip to content

Commit

Permalink
commenting more things out
Browse files Browse the repository at this point in the history
  • Loading branch information
lukey-luke committed Jan 23, 2025
1 parent 1e66818 commit 5a69478
Showing 1 changed file with 24 additions and 24 deletions.
48 changes: 24 additions & 24 deletions .github/workflows/docker_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,27 +82,27 @@ jobs:
- name: Build portal # this is run in parallel with the app build on jenkins, might break out to separate job
run: make ci-portals-v1

- name: Build, tag, and push docker image to Amazon ECR
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: api
IMAGE_TAG: hardcodedstringfornow
run: |
# REPOSITORIES=['api', 'attribution', 'aggregation', 'consent', 'web', 'web-admin', 'web-portal']
docker tag $REGISTRY/dpc-$REPOSITORY $REGISTRY/dpc-$REPOSITORY:$IMAGE_TAG
docker push $REGISTRY/dpc-$REPOSITORY:$IMAGE_TAG
#
# - name: Push artifacts
# run: | # tag
#
#
# use ECR to save the artifacts
# TODO convert over to GHA
# - name: ECR Login
# run: "log into ECR here and then push up images"
# docker.withRegistry("https://$docker_ecr") {
# for (component in ['web', 'web-admin', 'web-portal']) {
# docker.image("${docker_ecr}/dpc-${component}:latest").push()
# docker.image("${docker_ecr}/dpc-${component}:$version_tag").push()
# }
# }
# - name: Build, tag, and push docker image to Amazon ECR
# env:
# REGISTRY: ${{ steps.login-ecr.outputs.registry }}
# REPOSITORY: api
# IMAGE_TAG: hardcodedstringfornow
# run: |
## REPOSITORIES=['api', 'attribution', 'aggregation', 'consent', 'web', 'web-admin', 'web-portal']
# docker tag $REGISTRY/dpc-$REPOSITORY $REGISTRY/dpc-$REPOSITORY:$IMAGE_TAG
# docker push $REGISTRY/dpc-$REPOSITORY:$IMAGE_TAG
##
## - name: Push artifacts
## run: | # tag
##
##
# # use ECR to save the artifacts
# # TODO convert over to GHA
## - name: ECR Login
## run: "log into ECR here and then push up images"
## docker.withRegistry("https://$docker_ecr") {
## for (component in ['web', 'web-admin', 'web-portal']) {
## docker.image("${docker_ecr}/dpc-${component}:latest").push()
## docker.image("${docker_ecr}/dpc-${component}:$version_tag").push()
## }
## }

0 comments on commit 5a69478

Please sign in to comment.