BCDA-8360 add waf sync lambda #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpartridge
changed the title
carlpartridge
force-pushed
the
carl/BCDA-8360-add-waf-sync-lambda
branch
from
0981f4e to
6f5068b
Compare
lambda/wafsync/db.go
Outdated
|
|
||
| err = rows.Scan(&ip) | ||
| if err != nil { | ||
| log.Warningf("Scan error: %+v", err) |
There was a problem hiding this comment.
What do you think about bumping this to a fatal or error level? if scan fails on reading any of the IP set that should be updated, then that would mean that the IP allow list could be out of sync between database <> waf.
There was a problem hiding this comment.
What do you think about bumping this to a fatal or error level? if scan fails on reading any of the IP set that should be updated, then that would mean that the IP allow list could be out of sync between database <> waf.
I think error makes more sense as we already return nil, err on issue here. Also I think returning fatal is not recommended in lambdas.
| id: invoke-lambda | ||
| run: | | ||
| echo "STARTTIME=`date +%s`" >> "$GITHUB_OUTPUT" | ||
| aws lambda invoke --function-name bcda-dev-api-waf-sync test-result.txt |
There was a problem hiding this comment.
- if an error is returned; do we need to do any verification here or do we expect a non-zero exit code?
- do we want to add any additional validation for other cases where it runs successfully, but the end result might be different from what we expect; ie the update doesn't return an error, but there are no IPs in the WAF?
There was a problem hiding this comment.
- I believe returning nonzero is enough but Im not entirely sure how to force the function to error out in order to test. I copied a lot of this code from the DPC version, maybe its worth pinging them?
- I feel like that would best be solved via splunk or cloudwatch alerts? They could watch for a variety of things based off the logs? I can create a ticket to look into this, either creating new alerts or modifying the jenkins alerts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8360
🛠 Changes
Add WAF auto sync lambda
ℹ️ Context
We have recently switched over to WAF to control our allowlist of IP addresses. This lambda should sync our app DB with the source of truth on IP addresses to our WAF.
🧪 Validation
Local tests and linting passing.