Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify reference of master branch to main #176

Merged
merged 2 commits into from
May 25, 2024
Merged

modify reference of master branch to main #176

merged 2 commits into from
May 25, 2024

Conversation

christopher-maboh
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-326

🛠 Changes

Reference to master branch was changed to main

ℹ️ Context for reviewers

Github repository master branch renamed to main. changes made to reference main in jenkins instead of master

✅ Acceptance Validation

(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@christopher-maboh christopher-maboh requested a review from gsf May 24, 2024 22:33
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but missed this one:

* Engineers should keep aware of identifier collisions (and in some instances required migration order), and adjust their migration ID’s before merging with master, if necessary.

@christopher-maboh christopher-maboh merged commit eb6b3a8 into main May 25, 2024
5 checks passed
@christopher-maboh christopher-maboh deleted the PLT-326 branch May 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants