Merge fitWorkflow branch to basicMacroImplementation one #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using MC integration method
…using KDE efficiency and with the possibility of using pre-computed integrals
…-basicMacroImplementation (merged c6c1df9)
… rooFitResult objects (cherry picked from commit d3a0a7a)
…fitWorkflow Including README file and two minor fixes from working-basicMacroImplementation
…fitWorkflow Including from working-basicMacroImplementation splitting of dataset workspace and usage of folder for produced files
…macros, improve file managment in HTCondor executable
…fitWorkflow Including the use of ROOT batch mode in instructions
…tory structure, (3) included code to compute GEN-RECO deltaNLL in fit macro
…ns to include them, (2) sanity checks in run_preComp_Integrals_MC.sh macro
…s to GEN and fullAngular fit
Update workingFit-workflow branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed, the idea is to have just one branch which can be used both for the efficiency computation and to perform the fit to reco MC (useful for the SFs optimisation).
I created this branch, which is basically the same as working-fitWorkflow(*) in order to be able to see the real comparison wrt the base branch (as explained here).
(*)
git checkout -b official-fitWorkflow-toMerge origin/working-fitWorkflow
git merge origin/working-basicMacroImplementation