Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] External link component #676

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Aug 30, 2023

NOREF

Changes and Description

Got tired of copy and pasting the same component throughout the code base.

  • DRYing up code by adding a reusable ExternalLink component

How to test this change

  1. Go through links that will send people out of the MINT app still sends people
  2. Pay extra attention to the email ones

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested a review from a team as a code owner August 30, 2023 18:54
@garyjzhao garyjzhao requested review from patrickseguraoddball and ClayBenson94 and removed request for a team and patrickseguraoddball August 30, 2023 18:54
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Gary, just a small change to pass the label through translation

return (
<Link
href={href}
aria-label="Open in a new tab"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably have this passed through translation

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG TY

@garyjzhao garyjzhao merged commit 7d12527 into main Sep 6, 2023
9 checks passed
@garyjzhao garyjzhao deleted the NOREF/Explicit-external-link branch September 6, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants