Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3208] Update named statements to defer closure #672

Merged
merged 14 commits into from
Sep 11, 2023

Conversation

OddTomBrooks
Copy link
Contributor

@OddTomBrooks OddTomBrooks commented Aug 22, 2023

EASI-3208

Changes and Description

  • Update named statements to defer stmt.Close()

How to test this change

  • Visit the website
  • Try various actions which incur store calls
  • Assert that there are no emergent issues

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@OddTomBrooks OddTomBrooks requested a review from a team as a code owner August 22, 2023 21:17
@OddTomBrooks OddTomBrooks requested review from ClayBenson94 and removed request for a team August 22, 2023 21:17
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, but everything else looks great!

pkg/storage/namedstatements/cache.go Outdated Show resolved Hide resolved
@OddTomBrooks OddTomBrooks changed the title [EASI-3208] Update named statements to use a cache [EASI-3208] Update named statements to defer closure Sep 8, 2023
@OddTomBrooks OddTomBrooks merged commit 74d9b90 into main Sep 11, 2023
9 checks passed
@OddTomBrooks OddTomBrooks deleted the EASI-3208/fix_prepared_statement_leak branch September 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants