Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3128] Data exchange approach form #1433

Open
wants to merge 39 commits into
base: feature/MINT-2720_data_exchange
Choose a base branch
from

Conversation

patrickseguraoddball
Copy link
Contributor

MINT-3128

Description

  • Added form pages for DEA
  • Implemented React-Hook-Form
    • Added <AddNoteRHF /> to facilitate RHF for notes
    • Added support for useHandleMutation for RHF
    • Added <ConfirmLeaveRHF /> to facilitate RHF for browser confirm
  • Added unit tests
  • Added Cypress tests
  • Fixed a few misc unit tests and updated snapshots

How to test this change

  1. Verify all mutation saving on form works like Formik
  2. Verify Figma UX

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested review from StevenWadeOddball and garyjzhao and removed request for a team October 18, 2024 16:13
@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner October 21, 2024 16:33
@patrickseguraoddball patrickseguraoddball requested review from OddTomBrooks and removed request for a team October 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants