Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3166] data exchange cleanup #1416

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Oct 10, 2024

MINT-3166

Description

This PR looks to address feedback from other PRs that we didn't want to hold up merging to feature. It address some concerns in the code.

  1. Status calculations
    a. These were returning incorrect statuses ( changing completed to in progress on accident), ability to set back in progress
  2. Bool data type not set as a pointer in database or GO
  3. Store methods following the old receiver paradgim, and not using sql util get/ select receivers.
  4. No unit tests
  5. Remove core task list section

Note, this doesn't seek to address everything that could be cleaned up, only the sections noted above. Another PR might be needed later to finalize some changes.

How to test this change

  1. Ensure tests pass
  2. Update a data exchange approach with postman and confirm it works

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball requested a review from a team as a code owner October 10, 2024 18:15
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks and removed request for a team October 10, 2024 18:15
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good! I think since this PR might affect some other PRs in terms of merge conflicts, we might want to merge this in, update other branches with the new resolver / core task list section logic, then move on with some of the other Data Exchange PRs!

@ClayBenson94 ClayBenson94 merged commit eeffae9 into feature/MINT-2720_data_exchange Oct 11, 2024
7 of 11 checks passed
@ClayBenson94 ClayBenson94 deleted the task/MINT-3166_data_exchange_cleanup branch October 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants