-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINT-3166] data exchange cleanup #1416
Merged
ClayBenson94
merged 17 commits into
feature/MINT-2720_data_exchange
from
task/MINT-3166_data_exchange_cleanup
Oct 11, 2024
Merged
[MINT-3166] data exchange cleanup #1416
ClayBenson94
merged 17 commits into
feature/MINT-2720_data_exchange
from
task/MINT-3166_data_exchange_cleanup
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se struct functionality
StevenWadeOddball
requested review from
OddTomBrooks
and removed request for
a team
October 10, 2024 18:15
…ta_exchange_cleanup
ClayBenson94
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes all look good! I think since this PR might affect some other PRs in terms of merge conflicts, we might want to merge this in, update other branches with the new resolver / core task list section logic, then move on with some of the other Data Exchange PRs!
ClayBenson94
merged commit Oct 11, 2024
eeffae9
into
feature/MINT-2720_data_exchange
7 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINT-3166
Description
This PR looks to address feedback from other PRs that we didn't want to hold up merging to feature. It address some concerns in the code.
a. These were returning incorrect statuses ( changing completed to in progress on accident), ability to set back in progress
Note, this doesn't seek to address everything that could be cleaned up, only the sections noted above. Another PR might be needed later to finalize some changes.
How to test this change
PR Author Checklist
PR Reviewer Guidelines