Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3128] Data exchange approach translation #1415

Conversation

patrickseguraoddball
Copy link
Contributor

MINT-3128

Description

  • Added PlanDataExchangeApproachTranslation BE schema
  • Added types to FE translation.ts
  • Added translation configuration for DEA
  • Updated/ran export and util

How to test this change

  1. JSON exported correctly

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested review from OddTomBrooks, garyjzhao and StevenWadeOddball and removed request for a team October 10, 2024 17:45
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @patrickseguraoddball! I didn't verify all the translations etc, because it will be easier to catch anything once we hook this up to the change history test suite. We can make adjustments then if needed.

@patrickseguraoddball patrickseguraoddball merged commit dbad336 into feature/MINT-2720_data_exchange Oct 10, 2024
8 of 11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the MINT-3128/data-exchange-approach-translations branch October 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants