[MINT-3157] Plan Data Exchange Data Loader #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenWadeOddball
requested review from
OddTomBrooks and
ClayBenson94
and removed request for
a team
| @@ -77,3 +79,8 @@ func PlanDataExchangeApproachUpdate( | |||
| retDataExchangeApproach, err := storage.PlanDataExchangeApproachUpdate(store, logger, existing) | |||
| return retDataExchangeApproach, err | |||
| } | |||
|
|
|||
| // PlanDataExchangeApproachGetByModelPlanIDLoader calls a data loader to batch fetching a a plan data exchange object that corresponds to a model plan | |||
| func PlanDataExchangeApproachGetByModelPlanIDLoader(ctx context.Context, modelPlanID uuid.UUID) (*models.PlanDataExchangeApproach, error) { | |||
There was a problem hiding this comment.
With the introduction of this function, do we still need PlanDataExchangeApproachGetByID?
- resolvers.PlanDataExchangeApproachGetByID
- We should keep the
storagemethod by the same name, since it's used inresolvers.PlanDataExchangeApproachUpdate
ClayBenson94
approved these changes
Oct 11, 2024
…ta_exchange_data_loader
…ta_exchange_data_loader
…potentially replace get by id with loader calls
StevenWadeOddball
merged commit 57538b1
into
feature/MINT-2720_data_exchange
8 of 11 checks passed
StevenWadeOddball
deleted the
task/MINT-3157_data_exchange_data_loader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINT-3157
Description
This PR introduces a dataloader for the new type, plan data exchange. It uses the new version of dataloaders with generics.
--> Note, there is now generic sort and error functionality, but it still remains in PR. Once that is merged, this loader should also implement that sorting functionality, and error handling instead of the manual approach that happens in this PR.
--> Note, the failing front end tests are not caused by this PR, the FE development is still in progress.
--> This PR also introduces a generic function to validate the new loader structure. Effectively, a test suite just has to ensure that the data exists, and then specify a set of data to compare per key, and a function to specify how to compare it. This will remove a lot of the boiler plate code needed to test a new data loader.
How to test this change
PR Author Checklist
PR Reviewer Guidelines