Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3014] CR TDL Collab Card #1388

Conversation

patrickseguraoddball
Copy link
Contributor

MINT-3014

Description

  • Added <CRTDLCard />
  • Added unit test
  • Updated <ExternalLink /> component to render EChimp variation

How to test this change

  1. Verify matches Figma
  2. Verify modal render echimp variation

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested review from StevenWadeOddball, garyjzhao and OddTomBrooks and removed request for a team September 30, 2024 19:00
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card is looking good

@patrickseguraoddball patrickseguraoddball merged commit d716c00 into feature/MINT-1732_echimp-ffs-cr-tdl Oct 2, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the MINT-3014/cr-tdl-collab-card branch October 2, 2024 18:18
garyjzhao pushed a commit that referenced this pull request Oct 9, 2024
* Init card work

* Added unit test

* Added external link echimp prop and unit test

* Update beneficiaries test

* Updated unit test
garyjzhao pushed a commit that referenced this pull request Oct 11, 2024
* Init card work

* Added unit test

* Added external link echimp prop and unit test

* Update beneficiaries test

* Updated unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants