Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4017] GQL Modularization - Miscellaneous #1022

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

OddTomBrooks
Copy link
Contributor

@OddTomBrooks OddTomBrooks commented Mar 26, 2024

EASI-4017

Changes and Description

  • A wide variety of types have been extracted from the main gql schema into corresponding modules
  • A dummy endpoint was introduced to the main schema in order to define the Mutation type at a top-level
    • This endpoint is intentionally not implemented. As it should never be used, an error is expected.

How to test this change

  • Smoke test the application, particularly focusing on areas where modules have been refactored

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@OddTomBrooks OddTomBrooks marked this pull request as ready for review March 26, 2024 18:10
@OddTomBrooks OddTomBrooks requested review from a team as code owners March 26, 2024 18:10
@OddTomBrooks OddTomBrooks requested review from StevenWadeOddball and garyjzhao and removed request for a team March 26, 2024 18:10
# Conflicts:
#	pkg/graph/generated/generated.go
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom,

Looks good! Just a couple of changes requested. I smoke test the application and it functioned as expected.

pkg/graph/schema/schema.graphql Outdated Show resolved Hide resolved
pkg/graph/schema/schema.graphql Outdated Show resolved Hide resolved
pkg/graph/schema/types/operational_solution.graphql Outdated Show resolved Hide resolved
pkg/graph/resolvers/schema.resolvers.go Outdated Show resolved Hide resolved
pkg/graph/resolvers/operational_solution.resolvers.go Outdated Show resolved Hide resolved
@OddTomBrooks OddTomBrooks merged commit 90ab77c into main Mar 28, 2024
11 checks passed
@OddTomBrooks OddTomBrooks deleted the EASI-4017/gql_modularization_misc branch March 28, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants