Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/user upload/delete profile picture logic #93

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix/user upload/delete profile picture logic #93

merged 3 commits into from
Mar 20, 2024

Conversation

Nandan-18
Copy link
Contributor

Changes:

  • Upload new image to firebase only on save
  • Store firebase storage URL properly
  • On delete, autogenerate new gravatar
  • If profile is saved without changing picture, keep existing picture
  • Add loading circle during profile save

@Nandan-18 Nandan-18 enabled auto-merge March 20, 2024 08:44
@Nandan-18 Nandan-18 linked an issue Mar 20, 2024 that may be closed by this pull request
Uploaded image in edit-profile isn't stored as firebase storage path #86
Closed
@Nandan-18 Nandan-18 merged commit 620e0da into main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Logan9312 Logan9312 Logan9312 approved these changes

@Sundance636 Sundance636 Sundance636 approved these changes

@adviislam10 adviislam10 Awaiting requested review from adviislam10 adviislam10 is a code owner

@rustyRustacean rustyRustacean Awaiting requested review from rustyRustacean rustyRustacean is a code owner

@yifeng15 yifeng15 Awaiting requested review from yifeng15 yifeng15 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploaded image in edit-profile isn't stored as firebase storage path
3 participants
@Nandan-18 @Sundance636 @Logan9312