Add seek and tell functions from so3g.G3IndexedReader #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an implementation for seeking through a G3 file on disk, allowing faster parsing of data after the initial pass.
nwhitehorn
approved these changes
Aug 2, 2022
nwhitehorn
reviewed
Aug 2, 2022
| return boost::iostreams::seek(stream_, offset, std::ios_base::beg); | ||
| } | ||
|
|
||
| int G3Reader::Tell() { |
nwhitehorn
reviewed
Aug 2, 2022
| @@ -108,6 +108,14 @@ void G3Reader::Process(G3FramePtr frame, std::deque<G3FramePtr> &out) | |||
| n_frames_read_++; | |||
| } | |||
|
|
|||
| int G3Reader::Seek(int offset) { | |||
There was a problem hiding this comment.
This needs to be off_t rather than int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation for seeking through a G3 file for positions of particular frames, allowing faster parsing of data after the initial pass. Most efficient for streams containing many interleaved frame types.
Includes a test of the functionality using two passes through an existing data file, first to cache the desired frame position, and then to seek to that position.