Bug fix in detector pointing calculation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On rare occasions, the rotation angle about the boresight is computed as nan, due to round-off error causing the argument to acos to fall outside the valid range [-1, 1]. This PR addresses this rare edge case by specifically handling the cases where acos argument is outside the valid range.
nwhitehorn
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rare occasions, the rotation angle about the boresight is computed as nan,
due to round-off error causing the argument to acos to fall outside the valid
range [-1, 1]. This PR addresses this rare edge case by specifically handling
the cases where acos argument is outside the valid range.