Add option to suppress map weight object in map binner output. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful for e.g. mock observing where the weight matrix should be the same for every one of many maps and so is known a priori. For polarized maps, suppressing it can reduce RAM usage by a factor of four.
arahlin
approved these changes
Jun 24, 2021
| @@ -263,12 +271,14 @@ MapBinner::BinTimestream(const G3Timestream &det, double weight, | |||
| (*T)[detpointing[i]] += pcoupling.t*det[i]; | |||
| (*Q)[detpointing[i]] += pcoupling.q*det[i]; | |||
| (*U)[detpointing[i]] += pcoupling.u*det[i]; | |||
| (*W)[detpointing[i]] += mueller; | |||
| if (W) | |||
| (*W)[detpointing[i]] += mueller; | |||
There was a problem hiding this comment.
Should we even bother populating the mueller variable if it's not being stored?
There was a problem hiding this comment.
Good point. The compiler should actually optimize that out, but we can adjust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful for e.g. mock observing where the weight matrix
should be the same for every one of many maps and so is known a priori.
For polarized maps, suppressing it can reduce RAM usage by a factor of
four.