Counting flags #709
Merged
Counting flags #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this needs to be rebased when #702 is merged |
henryiii
reviewed
Mar 21, 2022
henryiii
reviewed
Mar 21, 2022
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
henryiii
approved these changes
Mar 21, 2022
github-actions
bot
added
the
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #694.
There was a simple way to address #694 by adding increasingly complex enable_if discriminations with the type, but that didn't really address what I consider to be the heart of the issue, which is that flags are treated different depending on the type and that can result in unexpected behavior as was observed in this issue.
This PR starts to address it, by adding
MultiOptionPolicy::Sumand a set of flag option defaults that is type dependent.The Sum option allows any type to act as a sum operator like was done before but doing it this way allows it to act on regular options, floating point values, or strings.
By adding the capability in that way we can simplify the conditionals on the add_flag and reduce one of the overloads. (it may be possible to get rid of more now but I don't want to try that here).