Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade googletest and drop GCC 4.7 support #160

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Upgrade googletest and drop GCC 4.7 support #160

merged 1 commit into from
Jul 25, 2019

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Sep 3, 2018

This seems to be hitting a bug in GoogleMock 1.8.1 that causes GCC 4.7 to fail. See google/googletest#1804 .

@henryiii henryiii changed the title Upgrade googletest Upgrade googletest (broken) Sep 3, 2018
@henryiii henryiii changed the title Upgrade googletest (broken) Upgrade googletest (placeholder) Jan 7, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #160    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          12     12            
  Lines        2212   1691   -521     
======================================
- Hits         2212   1691   -521
Impacted Files Coverage Δ
include/CLI/Formatter.hpp 100% <0%> (ø) ⬆️
include/CLI/Validators.hpp 100% <0%> (ø) ⬆️
include/CLI/Config.hpp 100% <0%> (ø) ⬆️
include/CLI/Option.hpp 100% <0%> (ø) ⬆️
include/CLI/App.hpp 100% <0%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <0%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <0%> (ø) ⬆️
include/CLI/Split.hpp 100% <0%> (ø) ⬆️
include/CLI/FormatterFwd.hpp 100% <0%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a46081...9203f60. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #160   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2880   2880           
=====================================
  Hits         2880   2880

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73aa158...79a7d8e. Read the comment docs.

@henryiii henryiii changed the title Upgrade googletest (placeholder) Upgrade googletest and drop GCC 4.7 support (placeholder) Feb 28, 2019
@henryiii henryiii force-pushed the googleup branch 2 times, most recently from 0bfcc6b to e09e0ed Compare July 25, 2019 14:14
@henryiii henryiii changed the title Upgrade googletest and drop GCC 4.7 support (placeholder) Upgrade googletest and drop GCC 4.7 support Jul 25, 2019
@henryiii henryiii merged commit e6aca64 into master Jul 25, 2019
@henryiii henryiii deleted the googleup branch July 25, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant