Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-clearing in tests #141

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Auto-clearing in tests #141

merged 4 commits into from
Jun 27, 2018

Conversation

henryiii
Copy link
Collaborator

Drops app.reset() in favor of automatic clearing if needed (parse() can now be used multiple times natively without extra work, even if an error is thrown and caught). A bug with the arg setting and ordering has been fixed; it was hidden in the tests due to a wrong placement of app.reset(). If you need to manually clear an app, app.clear() will do exactly what app.reset() used to do (consistent name with opt->clear()).

app.reset() was only intended for use in tests, so no DEPRECATED form provided.

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #141   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1686   1690    +4     
=====================================
+ Hits         1686   1690    +4
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb75b9...adff4a1. Read the comment docs.

@henryiii henryiii merged commit b453aeb into master Jun 27, 2018
@henryiii henryiii deleted the clear branch June 27, 2018 10:26
@henryiii henryiii added this to the v1.6 milestone Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant