Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async handlers for s3PathHandler and fileWriter #46

Merged
merged 13 commits into from
Nov 26, 2024
Merged

Conversation

tombch
Copy link
Collaborator

@tombch tombch commented Nov 19, 2024

This pull request introduces several changes to improve error handling, enhance user feedback, and refactor some components for better maintainability. The most important changes include adding a new ErrorModal component, updating the ExportModal and RecordModal to display errors within the GUI (rather than the console), and refactoring cell renderers in the ResultsPanel and Table components.

Error Handling Improvements:

  • lib/components/ErrorModal.tsx: Introduced a new ErrorModal component to display error messages in a modal. This includes ErrorModalContents for displaying the same form in other modals (i.e. the ExportModal).

Export Modal Enhancements:

Record Modal Enhancements:

Results Panel Enhancements:

Table Component Refactoring:

Other changes Copilot missed:

  • Made s3PathHandler and fileWriter mandatory arguments to Onyx.
  • Changed name of Filters panel back to Filter.
  • Added ExportStatus.WRITING page for state during file writing.
  • Added hardcoded support for rendering S3 links for ingest_report field.
  • Fixed record details page moving weirdly by ensuring autoheight is only applied to changes field.
  • Added 'Get Started with S3 buckets` advisory message for S3 errors (as that's the likely issue, otherwise its a genuine bug).
  • Added artificial delay for src/handlers fileWriter and s3PathHandler.

Copy link
Collaborator Author

@tombch tombch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me Tom

@tombch tombch merged commit da38575 into development Nov 26, 2024
4 checks passed
@tombch tombch deleted the async-handlers branch November 26, 2024 11:48
@tombch tombch mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant