Async handlers for s3PathHandler
and fileWriter
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve error handling, enhance user feedback, and refactor some components for better maintainability. The most important changes include adding a new
ErrorModal
component, updating theExportModal
andRecordModal
to display errors within the GUI (rather than the console), and refactoring cell renderers in theResultsPanel
andTable
components.Error Handling Improvements:
lib/components/ErrorModal.tsx
: Introduced a newErrorModal
component to display error messages in a modal. This includesErrorModalContents
for displaying the same form in other modals (i.e. theExportModal
).Export Modal Enhancements:
lib/components/ExportModal.tsx
: Added error handling state and logic to theExportModal
component, including displayingErrorModalContents
when an error occurs during export. [1] [2] [3] [4] [5]Record Modal Enhancements:
lib/components/RecordModal.tsx
: Updated theRecordModal
component to use the newErrorModal
for handling S3 report errors and refactored the export handling logic to use promises. [1] [2] [3] [4] [5] [6] [7] [8]Results Panel Enhancements:
lib/components/ResultsPanel.tsx
: Added error handling for S3 report errors using the newErrorModal
and refactored cell renderers for better modularity. [1] [2] [3] [4]Table Component Refactoring:
lib/components/Table.tsx
: Refactored theTable
component to remove the hardcodedclimb_id
cell renderer and use a more flexible approach with acellRenderers
map. [1] [2] [3] [4] [5]Other changes Copilot missed:
s3PathHandler
andfileWriter
mandatory arguments toOnyx
.Filters
panel back toFilter
.ExportStatus.WRITING
page for state during file writing.ingest_report
field.autoheight
is only applied tochanges
field.src/handlers
fileWriter
ands3PathHandler
.