Modif3mar2018 #99
Merged
Modif3mar2018 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this in the gx1 configuration, and it was BFB identical to #41158c1 for 3.5 years, when I stopped the run. Although the principal stress normalization is being done differently, the ellipse plots also appear identical (from iceh.2003-05.nc). Documentation for this and other changes to the dynamics still needs to be updated. I created an issue for that task.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: JF Lemieux, ECCC
Modified basal_stress_coeff to remove an if statement (following a suggestion by Till Rasmussen). I got BFB results.
There was a minus sign missing in the calculation of taubx and tauby for the outputs. This is just for the outputs. It does not affect the prognostic variables (e.g. uvel, vvel, vice, aice...).
Added internal pressure as an output (calculated in principal_stress). Possible names were sigI, internal_pressure, Pint, Pinternal and sigP. I decided to call it sigP. We could find a better name later if someone has an idea...
Normalization of sig1 and sig2 is now done with the ice strength for both evp and eap (instead of prs_sig for the evp). I removed prs_sig as it is not needed anymore. This does not change the prognostic variables (e.g. uvel, vvel, vice, aice...). This is just for diagnostic. I compared sig1 and sig2 obtained this way with the previous ones and they are the same where both are calculated (they are not calculated at all the same locations because of the new condition 'if (strength(i,j) > puny) then' in principal_stress compared to the old one 'if (prs_sig(i,j) > puny) then' .
Is the documentation being updated with this PR? N