Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icepack to #37e215b532 March 3, 2023 #821

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 14, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack to #37e215b532 March 3, 2023
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    All tests pass and are bit-for-bit except snwgrain test, answer changes expected. Full test suite run on cheyenne with 3 compilers,
7614 measured results of 7614 total results
7521 of 7614 tests PASSED
0 of 7614 tests PENDING
0 of 7614 tests MISSING data
93 of 7614 tests FAILED

new halochk tests failed without a prior baseline, snwgrain regression tests failed as expected.

  • How much do the PR code changes differ from the unmodified code?
    • bit for bit, except snwgrain tests
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Includes changes since Dec 7, 2022

  • Refactor Icepack optional arguments implementation
  • Fix bug in sublimation of snow
  • Updates to Icepack driver/scripts/port that don't affect CICE

@apcraig apcraig merged commit 03615e8 into CICE-Consortium:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants