Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD updates for icepack. #813

Merged
merged 4 commits into from
Mar 15, 2023
Merged

FSD updates for icepack. #813

merged 4 commits into from
Mar 15, 2023

Conversation

dabail10
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    This PR only updates the calls for the Icepack FSD bug fixes. FSD bug fixes Icepack#424
  • Developer(s):
    cmbitz (C. Bitz)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#8d8a2d7db8bc7021c2c3134653ffa2fddacb66a3
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This change was documented in the Icepack PR and is answer changing for all FSD active cases. This is just adding the hooks to CICE to call the new icepack interfaces.

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets set wlat(:)=c0 somewhere in one of the init flux routines. Some compiler checks will gag if an unset variable is passed into a subroutine.

@apcraig
Copy link
Contributor

apcraig commented Mar 15, 2023

FSDmods have been merged into Icepack. Please update Icepack in this PR and I'll do a final review before merging. I ran these changes with Icepack changes on cheyenne and everything should be working as expected, see CICE-Consortium/Icepack#424. Thanks.

@eclare108213
Copy link
Contributor

The docs badges on the main pages of both CICE and Icepack are indicating 'failing'

@dabail10
Copy link
Contributor Author

I have fast-forwarded to CICE main which includes the latest icepack version.

@apcraig
Copy link
Contributor

apcraig commented Mar 15, 2023

You also need to update Icepack explicitly to include the fsdmods. The current CICE has the latest Icepack prior to the fsdmods, this PR needs to update Icepack to include the fsdmods PR that was merged to Icepack last night.

@dabail10
Copy link
Contributor Author

Sorry, I was confused about that piece. Just updated to include the latest Icepack.

Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code + PR out, compared it to my earlier test sandbox, and everything looks good. Will merge soon unless anyone says wait.

@apcraig apcraig merged commit 7df80ba into CICE-Consortium:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants