Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modif to doc: advice for value of ndte #722

Merged
merged 1 commit into from
May 17, 2022

Conversation

JFLemieux73
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Advice in doc to increase nb of subcycles for high resolution applications
  • Developer(s):
    @JFLemieux73
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213
  • Please copy the PR test results link or provide a summary of testing completed below.
    N.A.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    @eclare108213 I have removed a sentence...please verify that this is ok. There might be a typo that I have not corrected yet. Look at "the elastic parameter E is also limited by stability" in section 3.1.3.3. Shouldn't it be Eo instead?

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. E and Eo are distinguished in section 2.5.3.2, and using E is fine in section 3.1.3.3 in my opinion.

@apcraig apcraig merged commit be8709b into CICE-Consortium:main May 17, 2022
dabail10 pushed a commit to ESCOMP/CICE that referenced this pull request Oct 4, 2022
@eclare108213 eclare108213 mentioned this pull request Nov 15, 2022
41 tasks
@JFLemieux73 JFLemieux73 deleted the DOCndte branch September 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants