Reduce number of calls to calc_ffrac #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
step_a calls calc_ffrac 6 times. These are two by two very similar. In order to half the number of calls and remove an if statement the function has been slightly refactored. step_a does not consume much time, thus this cannot be seen in the total timing.
tar
@eclare108213 @apcraig @JFLemieux73
#totl = 1214 total
#chkd = 1214 checked
#pass = 1198
#pend = 14
#miss = 2
#fail = 0
#failbuild = 0
#failrun = 0
#failtest = 0
#failcomp = 0
#failbfbc = 0
#failgen = 0
~