Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of calls to calc_ffrac #638

Merged
merged 6 commits into from
Oct 6, 2021

Conversation

TillRasmussen
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    step_a calls calc_ffrac 6 times. These are two by two very similar. In order to half the number of calls and remove an if statement the function has been slightly refactored. step_a does not consume much time, thus this cannot be seen in the total timing.
  • Developer(s):
    tar
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213 @apcraig @JFLemieux73
  • Please copy the PR test results link or provide a summary of testing completed below.
  • Testing has been forced to use eap in all cases
    #totl = 1214 total
    #chkd = 1214 checked
    #pass = 1198
    #pend = 14
    #miss = 2
    #fail = 0
    #failbuild = 0
    #failrun = 0
    #failtest = 0
    #failcomp = 0
    #failbfbc = 0
    #failgen = 0
    ~
  • How much do the PR code changes differ from the unmodified code?
    • [ x] bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • [ x] No
  • Does this PR add any new test cases?
    • Yes
    • [ x] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • [x ] No, does the documentation need to be updated at a later time?
      • Yes
      • [x ] No
  • Please provide any additional information or relevant details below:

@apcraig
Copy link
Contributor

apcraig commented Oct 6, 2021

Just as a check, I ran full test suites with 3 compilers on cheyenne and everything is bit-for-bit. I'll merge now.

@apcraig apcraig merged commit dc18f61 into CICE-Consortium:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants