Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onyx port, update unit test output #617

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 11, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Onyx port after significant Onyx system update, Update unit test output.

  • Developer(s):
    apcraig

  • Suggest PR reviewers from list in the column to the right.

  • Please copy the PR test results link or provide a summary of testing completed below.
    Testing on Onyx passes, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#85531cf8f8ae93f628344df6ecfa4be12e9629d8 although answers changes for Onyx due to new compilers. The failed tests are associated with the sumchk unit test. This seems to be an issue with the mpich implementation on Onyx with real4 and real16. The other test that fails is an alt04 test. This fails on a zap_snow_temperature error with only the Cray compiler. This may need some additional investigation in the future.

  • How much do the PR code changes differ from the unmodified code?

    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?

    • Yes
    • No
  • Does this PR add any new test cases?

    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)

    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

  • Update unit test output and scripts to differentiate completed runs and successful testing better

  • sumchk is not passing on Onyx due to issues in the global reduction at real16 and real4. This seems to be a software bug in mpich and a report has been issued to Onyx admins.

  • minor update to documentation to describe how the unit test scripts validate the unit test runs.

- Update unit test output and scripts to differentiate completed runs and successful testing better
- sumchk is not passing on Onyx due to issues in the global reduction at real*16 and real*4.  This seems to be a software bug in mpich and a report has been issued to Onyx admins.
@apcraig
Copy link
Contributor Author

apcraig commented Jul 14, 2021

I'll probably merge this in the next day or two unless I hear otherwise. Thanks.

@apcraig apcraig merged commit 0489cfd into CICE-Consortium:master Jul 14, 2021
@apcraig apcraig deleted the onyx1 branch August 17, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants