Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for RASM #593

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Updates for RASM #593

merged 1 commit into from
Apr 9, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 8, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Updates for RASM
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    full test suite run on cheyenne, all tests pass as expected, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#2d31fffac6e7fdf11434758e4bb68befccbcefd6
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Until we refactor the fixed bathymetry levels, we need the min(kmt,nlevel) otherwise the model will not run with kmt files used in coupled models (assuming they have more than 40 levels). Even with bathymetry and landice off, this code is executed and fails.

The other fix is associated with a renaming of the prognostic time manager variables names. This was done after the most recent RASM testing on the time manager branch, so that needed to be incorporated in the coupling layer.

Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@apcraig apcraig merged commit 2378740 into CICE-Consortium:master Apr 9, 2021
@apcraig apcraig deleted the c62rasm branch August 17, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants