Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icepack to latest version #580

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 17, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack to latest version
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    The CICE test suite is bit-for-bit with this PR, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#714dba689bfd2ab53298c93206add1e90bf1de3a.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

There have been several minor PRs to Icepack. This just keeps CICE up to date. Everything is bit-for-bit in the Icepack and CICE test suites, but could be non bit-for-bit in other cases. Updates included update to copyright/license, error tolerance for rare mushy thermo failure, trap for (hicen_init(n+1) - hicen_init(n))>0.

@apcraig apcraig merged commit d627ea2 into CICE-Consortium:master Mar 17, 2021
@apcraig apcraig deleted the ipup08 branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants