Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the README badges specifically related to code coverage #470

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Fix the README badges specifically related to code coverage #470

merged 4 commits into from
Jun 19, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jun 17, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Fix the README badges specifically related to code coverage
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    no testing done, just changes the README. Reviewed the README output in my branch,
    https://github.com/apcraig/CICE/tree/lcov02
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig apcraig merged commit 4b4af19 into CICE-Consortium:master Jun 19, 2020
@apcraig apcraig deleted the lcov02 branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@rallard77 rallard77 rallard77 approved these changes

Assignees
No one assigned
Labels
Documentation Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @rallard77