Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedi DA modifications #427

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Jedi DA modifications #427

merged 1 commit into from
Apr 10, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 2, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Implement JEDI DA Modifications recommended in NOAA JEDI data assimilation #419
  • Developer(s):
    jkbk2004, apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    full test suites run on conrad, everything passes bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#9ac1863e6b346a954d74110474e3b58d0f2345e4
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

See #419.

Updated the cart, rake, and spacecurve decompositions to compute blockCnt and blockIndex like the other decompositions. This is not needed, but the fact they weren't computed may have created some memory issues in the JEDI DA.

@apcraig apcraig merged commit d529df8 into CICE-Consortium:master Apr 10, 2020
@apcraig apcraig deleted the jedi_da branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants