Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaning up minor CICE documentation issues #397

Merged
merged 1 commit into from
Jan 30, 2020
Merged

cleaning up minor CICE documentation issues #397

merged 1 commit into from
Jan 30, 2020

Conversation

duvivier
Copy link
Contributor

@duvivier duvivier commented Jan 30, 2020 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Just a few minor changes to documentation ahead of tutorial
  • Developer(s):
    A. Duvivier
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    N/A
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    I've also changed the bulletin board labeling in all the wikis to "forum"

@duvivier duvivier requested a review from apcraig January 30, 2020 21:32
@duvivier duvivier changed the title cleaning up minor documentation cleaning up minor CICE documentation issues Jan 30, 2020
apcraig
apcraig approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look at the readthedocs and all looks good.

@apcraig apcraig merged commit 0011980 into CICE-Consortium:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duvivier @apcraig