Resolution to Issue #19 (single threaded runs crash) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e around loops that are not thread safe
apcraig
approved these changes
Sep 14, 2017
TillRasmussen
pushed a commit
to TillRasmussen/CICE
that referenced
this pull request
Nov 19, 2021
* split up atm and ocn forcing * Changed restore_ice = false for symtests * Added more box tests to gridsys_suite.ts. Modified several set_nml for use with new islands grid and uniform forcing * Fix for TPM. THis was also fixed by Dave bailey * Added CD forcing to boxslotcyl forcing data * ice_init.F90: moved grid_average_X2Y to be in proper place after set_state_var. ice_grid.F90: modified variable declaration in gridaverage_X2Y to use (:,:,:) for dimensions of passed arrays * Bug fix in ice_grid.F90:get_box_kmt. Need to first initialize land mask to c1 before adding land locations * ice_grid.F90 - renamed subroutine box_grid_kmt to grid_boxislands_kmt. Changed names of set_nml to remove underscores. Updated gridsys_suite to be consistent with set_nml. * revert boxadv to have ktherm=0. Change gridsys_suite.ts options to run box test on multple PEs. Removed boxadv from gridsys_suite.ts * Clean up blank lines and unused use statements. Removed check for uniform atm_data_type in get_forcing_atmo Co-authored-by: apcraig <anthony.p.craig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes fixes to the OpenMP code (removing OpenMP directives) that correspond to loops that do not appear to be thread safe.
Developer(s): Matthew Turner
Updated documentation (Y/N): N/A
Results (bit for bit, roundoff, climate changing): Bit for bit comparison PASSed
Code review:
Other Relevant Details:
This resolves issue 19