Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POP tx1 grid. #201

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Add POP tx1 grid. #201

merged 4 commits into from
Oct 9, 2018

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented Oct 9, 2018

I have added support for the tx1 POP tripole grid. There is also a test added to base_suite here. Currently it uses the uniform climatological forcing and ice_ic = 'default'. It is mainly for testing purposes. I will add the tripole grid and kmt files to the ftp downloads.

  • Developer(s): D. Bailey

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? BFB

  • Please include the link to test results or paste the summary block from the bottom of the testing output below.

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) Y
    If not, does the documentation need to be updated separately at a later time? (Y/N)

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

@dabail10
Copy link
Contributor Author

dabail10 commented Oct 9, 2018

The checks are failing because the tx1 grid files need to be loaded onto the Travis server.

@apcraig
Copy link
Contributor

apcraig commented Oct 9, 2018

Travis seems to be failing due to changes to the ftp input file names. We need to get this resolved. I don't think the tx1 files are needed on the travis server as the travis_suite does not test it.

@apcraig apcraig merged commit c4ec86f into CICE-Consortium:master Oct 9, 2018
@dabail10 dabail10 deleted the tripole branch June 12, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants