Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icepack interface for binary restarts #148

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

eclare108213
Copy link
Contributor

Added Icepack interface calls to binary restart module and isolated netcdf bgc code.

  • Developer(s): E. Hunke

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? BFB

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

The modal_aero option requires netcdf input, so I added an abort if modal_aero=T and netcdf is not available. @njeffery is it possible to include this data directly in the code or provide binary for it?

The change to io/netcdf/ice_restart.F90 is cosmetic.

This PR is not yet fully tested, just trying to keep Rob going...

@eclare108213
Copy link
Contributor Author

Smoke and restart tests using binary I/O work. These options must be set in ice_in to run them:

ice_ic         = 'default' or 'none'
restart        = .false.

Ran the base_suite; results are at https://github.com/CICE-Consortium/Test-Results/wiki/e203dcbf71.pinto.intel.180608.172808

pinto_intel_restart_gx1_40x4_debug_droundrobin failures are because this case asks for 10 nodes, but the maximum number of nodes that can be requested is 5, for the standard qos on pinto. This will always fail on pinto. The other failure is for a box configuration, which still needs to be debugged.

This PR should be ready to merge.

@njeffery
Copy link
Contributor

njeffery commented Jun 8, 2018 via email

@apcraig apcraig merged commit 837b3bf into CICE-Consortium:master Jun 13, 2018
@eclare108213 eclare108213 deleted the binary branch October 28, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants