spirv_hip_fp16.h header file updates #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially updated the
spirv_hip_fp16.h
based on rocm release 6.1.0 and added the needed ocml functions tospirv_math_fwd.h
(tested the ocml functions and worked well).The parts of spirv_hip_fp16.h left unmodified includes:
#if __HIP_CLANG_ONLY__
was updated to#if defined(__clang__) && defined(__HIP__)
in the new release(Note:
__llvm_rcp_f16
and__llvm_rcp_2f16
defines are removed as they are no longer used in the updated header file (implementation was changed from using those to using direct operations (such as division))