Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Fixes #844

Merged
merged 15 commits into from
May 7, 2024
Merged

Small Fixes #844

merged 15 commits into from
May 7, 2024

Conversation

pvelesko
Copy link
Collaborator

@pvelesko pvelesko commented May 5, 2024

  • Add a test which runs valgrind to check that no additional thread safety issues are introduced
  • CMake fixes enabling to recompile the code with modules unloaded
  • CMake fixes to prevent repeated building of hipInfo and ccompat
  • Various other small fixes

@pvelesko pvelesko force-pushed the small-fixes-may4 branch 2 times, most recently from 5a5778d to a852766 Compare May 5, 2024 10:30
@pvelesko pvelesko requested a review from linehill May 6, 2024 02:41
Copy link
Collaborator

@linehill linehill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pvelesko pvelesko merged commit 339defd into main May 7, 2024
29 checks passed
@pvelesko pvelesko deleted the small-fixes-may4 branch May 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants