-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase HIP 6.x + Update hip-tests #796
Conversation
Seeing a lot of these as well as a lot more test failures even some basic tests such as
|
Probably just a false positive. I wrote the warning at a time I didn’t fully understood what was happening (__hipRegisterFuntcion() called multiple times with same host pointer). I made a patch to remove it: #809. |
FYI, building this branch from scratch with multiple jobs may end up in a situation where hipcc is not built before building hip-tests:
|
Removing the |
9836634
to
6162e88
Compare
* Update CHIPBindings to include new API
* Support --genco option
Without this, hip-tests runs into a compilation/linking issue DWARF error: invalid or unhandled FORM value: 0x23
This covers printf() uses involving casts from integer literals to pointers. Should fix #798.
5a74531
to
05da6d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please run clang-format for the whole patch set. E.g. with
git clang-format main
. - Did you check if there are new
hipDeviceProp_t
andhipDeviceAttribute_t
entries and updatedhipGetDeviceProperties()
andhipDeviceGetAttribute()
to respond to them?
done
Yes there changes to these but since we decided to stick with the old tests for the time being it doesn't make sense to update these and have two sets of broken unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Update HIP version from 5.1 to 6.x
Update hip-tests submodule
Update HIPCC
--genco
option. Reduces changes needed for upstreamingThe following individual tests are still excluded, mostly due to failures in LLVM-SPIRV-Translator
The following test categores are excluded due to unsuported features.
Occupancy
Surface - not implemented:
Texture - not implemented:
One final caveat: test discovery happens at runtime, every single time.. This means that to run a single test, we need to discover all the tests first. Adds 70 seconds overhear for launching a single test.Total number of tests 975 -> 1898