PMP: todo: Fix slow compute_vertex_normal() #8684
Open
+1,252
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls are slightly perturbed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
For the testcase provided in this PR
compute_vertex_normal()is particularly slow. A vertex has a fan of incident faces with identical normal. As the first fix tests withoperator==(Vector_3,Vector_3)it is still slow when the object is slightly rotated or perturbed. With a bound on the angle between normals it is fixed, but is that acceptable? Fordoubleprobably. Do we have to specialize for exact number types?Release Management