Periodic_3_mesh_3: Avoid Making Copies #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelRL
reviewed
Dec 6, 2024
MaelRL
reviewed
Dec 6, 2024
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
MaelRL
approved these changes
Dec 6, 2024
|
Only 1 timeout in CGAL-6.1-Ic-37 vs 13 in CGAL-6.1-I-36 Successfully tested |
sloriot
added
Tested
rm only: ready for master
|
Note that this a timeout when in Release mode with CGAL_NDEBUG. Should it be investigated? |
I would not bother, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Turn several copies into
const&to avoid allocation of data members of traits object with multiprecision coordinates. In release mode the gain is around 10%..To address the timeouts in the testsuite in Debug mode, I also changed cell size and approximation error.
Release Management