PMP: Add vertex_angle_sum() #8564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelRL
added
Small feature
TODO
Pkg::PMP
Not yet approved
|
merged with #6088. |
MaelRL
added
Replaced
and removed
Not yet approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The vertex angle sum can be used as an indication for local flatness.
Writing it I am wondering if we need a generic apply functors to vertices.
The name itself must be discussed. Should it be
compute_..?I would also like to see integrated this function in the demo where we color code. I am wondering what to do with border vertices where the sum is in general not 2 pi
Release Management