Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance-unnecessary-value-param check #739

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add performance-unnecessary-value-param check #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ Checks: >
-modernize-use-trailing-return-type,
performance-*,
-performance-enum-size,
-performance-unnecessary-value-param,
portability-*,
readability-*,
-readability-function-cognitive-complexity,
Expand Down
14 changes: 8 additions & 6 deletions tests/splines/splines_linear_problem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
namespace DDC_HIP_5_7_ANONYMOUS_NAMESPACE_WORKAROUND(MATRIX_CPP) {

void fill_identity(
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS mat)
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const& mat)
{
for (std::size_t i(0); i < mat.extent(0); ++i) {
for (std::size_t j(0); j < mat.extent(1); ++j) {
Expand All @@ -34,7 +34,7 @@ void fill_identity(
}

void copy_matrix(
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS copy,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const& copy,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultExecutionSpace> const& mat)
{
assert(mat.size() == copy.extent(0));
Expand All @@ -48,8 +48,9 @@ void copy_matrix(
}

void check_inverse(
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS matrix,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS inv)
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const&
matrix,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const& inv)
{
double const TOL = 1e-10;
std::size_t const N = matrix.extent(0);
Expand All @@ -66,8 +67,9 @@ void check_inverse(
}

void check_inverse_transpose(
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS matrix,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS inv)
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const&
matrix,
ddc::detail::SplinesLinearProblem<Kokkos::DefaultHostExecutionSpace>::MultiRHS const& inv)
{
double const TOL = 1e-10;
std::size_t const N = matrix.extent(0);
Expand Down
Loading